Add metadat copy/apply-diff, new testing framework #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
requested review from
lseelenbinder,
sharkAndshark,
upsicleclown and
birkskyum
nyurik
force-pushed
the
insta
branch
10 times, most recently
from
9d50970 to
1e749c6
Compare
* Generate SQLite DBs in memory on the fly to validate just what we need * Use `insta` for validating all outputs * Fix metadata copying * Introduce a new metadata field `agg_tiles_hash_after_apply` for diff files * Added a lot of new info and debug logging
birkskyum
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
agg_tiles_hash_after_applyfor diff filesTesting
instafor validating DB contentThere is now a function
dump(connection) -> Vec<Entry>to dump the content of the entire SQLite DB into text withserde. At many steps through the testing, the DB content is validated with the corresponding .snap file withinstacrate (which makes this process mega-simple, including a simple way to "bless" (update) any changes).Discovered bugs