-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clip_geom, buffer and extent under auto_publish conf #887
Conversation
martin/src/pg/table_source.rs
Outdated
pub async fn query_available_tables(pool: &PgPool) -> Result<SqlTableInfoMapMapMap> { | ||
pub async fn query_available_tables( | ||
pool: &PgPool, | ||
clip_geom: Option<bool>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, but it might be better to actually change buffer
and clip_geom
here to None
to indicate that we don't have them yet, and keep them unset until much later as part of the instantiate_tables
somewhere around db_inf.srid = srid;
line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyurik I was thinking of this also,how about here:
...
db_inf.srid = srid;
update_id_column(&id2, &mut db_inf, auto_tables);
impose_clip_geom(&mut db_inf, auto_tables);
impose_buffer(&mut db_inf, auto_tables);
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, just maybe it will make sense to rename the update_id_column
to update_auto_fields
and do all these steps inside one function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nyurik Have a good day! :)
It's still a draft, but could you help me a code review in case of any big misunderstanding?
3eb6ea7
to
ad4b0fe
Compare
ad4b0fe
to
d984329
Compare
d984329
to
d3de380
Compare
I made a few fixes in sharkAndshark#52 Once merged, should be good to go |
add extent, fix a few things
Looks good, needs docs too |
9cb4080
to
5b13924
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Partly fix #872