Make tile service GoogleMaps-Compatible when the cog file is GoogleMapsCompatible #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still a concept proofing draft. |
sharkAndshark
commented
Dec 30, 2024
| ) -> Result<(Option<String>, Option<u8>), CogError> { | ||
| let gdal_metadata = decoder | ||
| .get_tag_ascii_string(Tag::Unknown(42112)) | ||
| .map_err(|e| CogError::TagsNotFound(e, vec![42112], 0, PathBuf::new()))?; |
There was a problem hiding this comment.
Just return None. It's normal a tiff file have no tag 42112
| @@ -75,9 +79,14 @@ impl Source for CogSource { | |||
| Decoder::new(tif_file).map_err(|e| CogError::InvalidTiffFile(e, self.path.clone()))?; | |||
| decoder = decoder.with_limits(tiff::decoder::Limits::unlimited()); | |||
|
|
|||
| let ifd = self.meta.zoom_and_ifd.get(&(xyz.z)).ok_or_else(|| { | |||
| let actual_zoom = if let Some(google_zoom) = self.meta.google_compatible_max_zoom { | |||
There was a problem hiding this comment.
should calculate the actual_x and actual_y either.
sharkAndshark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDAL provides an interesting option when creating COG, TILING_SCHEME=[CUSTOM/GoogleMapsCompatible/...]
The goal of this PR is to allow frontend could use the googlemaps-compatible cog without extra steps(like make a custom tile grid), as google tilling schema seems is the most widely used schema, almost every JS lib support it( even only support it.)
LIke if we hanve a tiff file which is from zoom 0 - zoom 5 and it's googlemaps-compatible.
So there is a mapping from tiff-internal-xyz to google-map-xyz, I'm wondering if we could take this mapping and pretending that it's a tile source which use google tilling schema.
A sample like below:
Update the tilejson
To implement this, we could update the tilejson
{ ..., // tell user the zoom level is from 9-14 instead of 0-5 "min_zoom": 9, "max_zoom": 14, ... }Convert the user requested zxy internally
To implement this, we could transform the resquested xyz to the actuall xyz of tiff tile
/14/0/0/5/4/3