-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cargo binstall support #1012
Conversation
This is exactly what i was looking for, thank you!!! Let me know when ready to merge. Although one thing: we will need to merge this right before the release, or else we will have incorrect documentation links for a while, and that wouldn't be good. |
As there is no convenient way to verify this PR works, I explain it here. To install packages,
The default pkg-url template in this PRThe default pkg-url template in this PR is For cargo binstall martin --version 0.10.0 -v
...
DEBUG Checking for package at: 'https://github.com/maplibre/martin/releases/download/0.10.0/martin-x86_64-unknown-linux-gnu-v0.10.0.tar'
...
DEBUG Checking for package at: 'https://github.com/maplibre/martin/releases/download/0.10.0/martin-x86_64-unknown-linux-gnu-v0.10.0.tar.bz2'
...
DEBUG Checking for package at: 'https://github.com/maplibre/martin/releases/download/0.10.0/martin-x86_64-unknown-linux-gnu-v0.10.0.tar.gz'
..
DEBUG Checking for package at: 'https://github.com/maplibre/martin/releases/download/v0.10.0/martin-x86_64-unknown-linux-gnu-v0.10.0.zip'
...
DEBUG Checking for package at: 'https://github.com/maplibre/martin/releases/download/0.10.0/martin-x86_64-unknown-linux-musl-v0.10.0.zip'
... So update the package names in this PR. bin and bin-dir in this PR
So keep file names still in this PR. |
Update martin download links. See these issue and PR either. * [Standardize release filenames and add cargo binstall support](maplibre/martin#1005) * [Add cargo binstall](maplibre/martin#1012)
I have merged the CI part of this PR directly into the main branch, and will release it as a pre-release. Once all works and checks out, I will merge this PR as well. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks once again!
Try to fix #1005
mbtiles