Use printf for generating version.go #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flag -e is to "enable interpretation of backslash escapes" Which might be a default, depends on a shell. sh -c 'echo "a\nb"' on my OS prints "a\nb" (no newline)
starsep
force-pushed
the
versionGoEchoE
branch
from
2d7b1e1 to
6736eb2
Compare
|
Seems like this breaks the CI... |
|
Indeed.
I suspect also |
|
Thanks! |
starsep
changed the title
|
heh, that's why i prefer just, optionally with per-platform targets |
|
@nyurik did you review this PR? can it be merged? |
nyurik
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flag -e is to "enable interpretation of backslash escapes"
Which might be a default, depends on a shell.
sh -c 'echo "a\nb"'on my OS prints(no newline)
Launch Checklist