Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MapLibre dependencies, add terrain editing #859

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Jan 11, 2024

This PR aims at updating MapLibre dependencies.

The main goal of this update is to allow adding terrain specification to the editor.
This requires version 4 of maplibre so currently it will use the pre-release.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9409b34:

Sandbox Source
maputnik Configuration

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarelM
Copy link
Collaborator Author

HarelM commented Jan 11, 2024

This is great, I wanted to make sure the tests will fail as the update broke the hover ability in the settings modal.

@HarelM
Copy link
Collaborator Author

HarelM commented Jan 11, 2024

Assuming the tests will pass this is ready for review/merge.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@HarelM HarelM changed the title Update MapLinbre dependencies Update MapLibre dependencies Jan 11, 2024
@HarelM HarelM changed the title Update MapLibre dependencies Update MapLibre dependencies, add terrain editing Jan 11, 2024
@HarelM HarelM merged commit eb48bed into maplibre:main Jan 11, 2024
7 checks passed
@HarelM HarelM deleted the maplibre-4 branch January 11, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants