Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #854

Merged
merged 12 commits into from
Dec 27, 2023
Merged

Improve tests #854

merged 12 commits into from
Dec 27, 2023

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Dec 26, 2023

Recover commented out tests,
Improve usage of helper in driver,
Added data-wd-key for test to use instead of classes
Moved all non tsx file to a single folder (lib) instead of lib and utils

@HarelM HarelM requested review from nyurik and birkskyum December 26, 2023 22:53
Copy link

codesandbox-ci bot commented Dec 26, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5235ef8:

Sandbox Source
maputnik Configuration

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09a1f3f) 56.77% compared to head (5235ef8) 57.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   56.77%   57.18%   +0.40%     
==========================================
  Files         104      104              
  Lines        2929     2929              
  Branches      674      674              
==========================================
+ Hits         1663     1675      +12     
+ Misses       1266     1254      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit b784bf2 into maplibre:main Dec 27, 2023
8 checks passed
@HarelM
Copy link
Collaborator Author

HarelM commented Dec 27, 2023

Thanks @nyurik!! You are working in weird hours... :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants