Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code coverage #852

Merged
merged 12 commits into from
Dec 26, 2023
Merged

add code coverage #852

merged 12 commits into from
Dec 26, 2023

Conversation

ShellyDCMS
Copy link
Collaborator

@ShellyDCMS ShellyDCMS commented Dec 25, 2023

Add Cypress code coverage using Istanbul nyc
image

@ShellyDCMS ShellyDCMS marked this pull request as ready for review December 25, 2023 04:45
@HarelM
Copy link
Collaborator

HarelM commented Dec 25, 2023

Please add output file to fit ignore (out.json).

@HarelM
Copy link
Collaborator

HarelM commented Dec 25, 2023

Can you grant me permissions to your repo?
I'll fix the package lock and add the codecov CI step.

Copy link

codesandbox-ci bot commented Dec 25, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f9e0794:

Sandbox Source
maputnik Configuration

@HarelM
Copy link
Collaborator

HarelM commented Dec 25, 2023

I have fixed the package lock but it seems that the coverage is causing the test to fail for some reason.
I was able to reproduce this locally in codespaces when running the tests using command line (headless).
I also found this closed issue, which sounds similar, but it looks like it was fixed in latest version, so I don't know:
cypress-io/code-coverage#216

image

@HarelM
Copy link
Collaborator

HarelM commented Dec 25, 2023

THANKS BTW!

@ShellyDCMS
Copy link
Collaborator Author

I have fixed the package lock but it seems that the coverage is causing the test to fail for some reason. I was able to reproduce this locally in codespaces when running the tests using command line (headless). I also found this closed issue, which sounds similar, but it looks like it was fixed in latest version, so I don't know: cypress-io/code-coverage#216

image

Is this still an issue? it seems we just need to add baseUrl

@HarelM
Copy link
Collaborator

HarelM commented Dec 26, 2023

Yes, this is still an issue, you can see it in the Firefox CI run.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@ShellyDCMS
Copy link
Collaborator Author

Yes, this is still an issue, you can see it in the Firefox CI run.

Fixed

.nycrc.json Show resolved Hide resolved
Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS!

@HarelM
Copy link
Collaborator

HarelM commented Dec 26, 2023

Nice (besides the low number obviously)!
image

@HarelM HarelM merged commit a324ddb into maplibre:main Dec 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants