-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration of jsx files to tsx 3 #851
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6975bf2:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
That was fast. |
its ok if they are very similar to this change to push them here and squash them after |
Ok, I'll push them here then, the changes are mainly to add types and rename the files. |
This is now ready for review. As far as I could tell the release process is by building it in this repo and copying the files to the maputnik.io repo. Lint and code coverage are probably the next steps, and later on packages upgrade when the coverage is OK, or if someone can define a way to make sure the build is OK manually. |
This is in continue to:
The last files should be converted as part of this PR, there are only a handful left.