Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of jsx files to tsx 3 #851

Merged
merged 6 commits into from
Dec 25, 2023
Merged

Migration of jsx files to tsx 3 #851

merged 6 commits into from
Dec 25, 2023

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Dec 22, 2023

This is in continue to:

The last files should be converted as part of this PR, there are only a handful left.

Copy link

codesandbox-ci bot commented Dec 22, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6975bf2:

Sandbox Source
maputnik Configuration

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HarelM
Copy link
Collaborator Author

HarelM commented Dec 22, 2023

That was fast.
Do you prefer that I open a new PR or pile the rest of the files as part of this PR?

@nyurik
Copy link
Member

nyurik commented Dec 22, 2023

its ok if they are very similar to this change to push them here and squash them after

@HarelM
Copy link
Collaborator Author

HarelM commented Dec 22, 2023

Ok, I'll push them here then, the changes are mainly to add types and rename the files.
It shouldn't take more than a few work hours to finish this.

@HarelM
Copy link
Collaborator Author

HarelM commented Dec 24, 2023

This is now ready for review.
I have completed the migration.
It's not perfect, but it's a lot better than before.
I also fixed some console errors and warnings.
I'm not an experienced Maputnik user, so this probably needs some more testing before it can be released.

As far as I could tell the release process is by building it in this repo and copying the files to the maputnik.io repo.
It might be a good idea to maybe create an npm package with the build outputs to allow versioning.

Lint and code coverage are probably the next steps, and later on packages upgrade when the coverage is OK, or if someone can define a way to make sure the build is OK manually.

@HarelM HarelM requested a review from birkskyum December 24, 2023 08:27
src/libs/apistore.ts Show resolved Hide resolved
@HarelM HarelM merged commit 656264f into maplibre:main Dec 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants