Fix lint, add test

maplibre · Feb 4, 2024 · 0b26fc8 · 0b26fc8
1 parent bc37ef3
commit 0b26fc8
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 29 deletions.
diff --git a/cypress/e2e/map.cy.ts b/cypress/e2e/map.cy.ts
@@ -23,4 +23,10 @@ describe("map", () => {
       );
     });
   });
+
+  describe("search", () => {
+    it('should exist', () => {
+      then(get.searchControl()).shouldBeVisible();
+    });
+  });
 });
diff --git a/cypress/e2e/maputnik-driver.ts b/cypress/e2e/maputnik-driver.ts
@@ -177,5 +177,6 @@ export class MaputnikDriver {
     skipTargetLayerEditor: () =>
       this.helper.get.elementByTestId("skip-target-layer-editor"),
     canvas: () => this.helper.get.element("canvas"),
+    searchControl: () => this.helper.get.element('.maplibregl-ctrl-geocoder')
   };
 }
diff --git a/src/components/MapMaplibreGl.tsx b/src/components/MapMaplibreGl.tsx
@@ -233,38 +233,38 @@ export default class MapMaplibreGl extends React.Component<MapMaplibreGlProps, M
   initGeocoder(map: Map) {
     const geocoderConfig = {
       forwardGeocode: async (config:{query: string, limit: number, language: string[]}) => {
-          const features = [];
-          try {
-              const request = `https://nominatim.openstreetmap.org/search?q=${config.query}&format=geojson&polygon_geojson=1&addressdetails=1`;
-              const response = await fetch(request);
-              const geojson = await response.json();
-              for (const feature of geojson.features) {
-                  const center = [
-                      feature.bbox[0] +
+        const features = [];
+        try {
+          const request = `https://nominatim.openstreetmap.org/search?q=${config.query}&format=geojson&polygon_geojson=1&addressdetails=1`;
+          const response = await fetch(request);
+          const geojson = await response.json();
+          for (const feature of geojson.features) {
+            const center = [
+              feature.bbox[0] +
                   (feature.bbox[2] - feature.bbox[0]) / 2,
-                      feature.bbox[1] +
+              feature.bbox[1] +
                   (feature.bbox[3] - feature.bbox[1]) / 2
-                  ];
-                  const point = {
-                      type: 'Feature',
-                      geometry: {
-                          type: 'Point',
-                          coordinates: center
-                      },
-                      place_name: feature.properties.display_name,
-                      properties: feature.properties,
-                      text: feature.properties.display_name,
-                      place_type: ['place'],
-                      center
-                  };
-                  features.push(point);
-              }
-          } catch (e) {
-              console.error(`Failed to forwardGeocode with error: ${e}`);
+            ];
+            const point = {
+              type: 'Feature',
+              geometry: {
+                type: 'Point',
+                coordinates: center
+              },
+              place_name: feature.properties.display_name,
+              properties: feature.properties,
+              text: feature.properties.display_name,
+              place_type: ['place'],
+              center
+            };
+            features.push(point);
           }
-          return {
-              features
-          };
+        } catch (e) {
+          console.error(`Failed to forwardGeocode with error: ${e}`);
+        }
+        return {
+          features
+        };
       }
     };
     const geocoder = new MaplibreGeocoder(geocoderConfig, {maplibregl: MapLibreGl});