-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index-of
and slice
expression Android 11.0.0
#362
Conversation
@louwers any updates on this? Can this be merged? |
@HarelM No it is not released yet. |
Just an FYI, I just made a PR that adds 'slice' and 'index-of' to node also If this gets merged does the node version need to be added similar to this PR? |
@acalcutt We are not currently tracking style support of Node.js. As you can see: https://maplibre.org/maplibre-style-spec/expressions/ If you want to, you can add it, but you'd have to go over all the other things as well! |
I didn't see this PR earlier when creating maplibre/maplibre-native#2078 but I believe the style-expression changes should be backported to Android maplibre 10.x, too. It's not a breaking change, so it makes sense to provide it for Android maplibre 10.x instead of Android maplibre 11.x. Backporting them would also make them available immediately; which is probably better than waiting for Android maplibre 11.x to be completed. |
@louwers this is a reminder since I saw you are creating apre release of 11. |
I didn't even remember this PR; it should be changed to 10.3.x after maplibre/maplibre-native#2135 (which should have been released already) |
There's no official release out with these features. |
@louwers didn't you release version 11? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
=======================================
Coverage 92.56% 92.56%
=======================================
Files 104 104
Lines 4616 4616
Branches 1301 1301
=======================================
Hits 4273 4273
Misses 343 343 ☔ View full report in Codecov by Sentry. |
Will remove Draft status of this PR once 11.0.0 has been released.
Resolves #159