-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only non-send futures #77
Open
maxammann
wants to merge
15
commits into
maplibre:main
Choose a base branch
from
maxammann:only-non-send-futures
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think input from a rust expert would be nice here... |
# Conflicts: # maplibre/Cargo.toml # maplibre/src/io/scheduler.rs # maplibre/src/io/source_client.rs # maplibre/src/platform/noweb/http_client.rs # maplibre/src/platform/noweb/schedule_method.rs
maxammann
force-pushed
the
main
branch
3 times, most recently
from
June 3, 2022 09:54
8c5d8ee
to
4dbd47b
Compare
maxammann
changed the title
Use only non-send futures
Postphoned until needed: Use only non-send futures
Nov 12, 2022
maxammann
changed the title
Postphoned until needed: Use only non-send futures
Postponed: Use only non-send futures
Nov 19, 2022
maxammann
added
the
pr-postponed
Postponed PR, which is not needed right now but might be needed (contains valuable information)
label
Nov 19, 2022
nyurik
previously approved these changes
Nov 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! Have you considered to use the nightly async trait feature?
lolpro11
approved these changes
Oct 5, 2023
# Conflicts: # maplibre/Cargo.toml # maplibre/src/io/scheduler.rs # maplibre/src/io/source_client.rs # maplibre/src/platform/noweb/http_client.rs # maplibre/src/platform/noweb/schedule_method.rs # web/Cargo.toml
maxammann
changed the title
Postponed: Use only non-send futures
Use only non-send futures
Oct 20, 2023
maxammann
removed
the
pr-postponed
Postponed PR, which is not needed right now but might be needed (contains valuable information)
label
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async Rust is a mess.
💻 Examples
🚨 Test instructions
✔️ PR Todo