Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Expo SDK 52 #489

Merged
merged 8 commits into from
Nov 15, 2024
Merged

chore: upgrade Expo SDK 52 #489

merged 8 commits into from
Nov 15, 2024

Conversation

KiwiKilian
Copy link
Collaborator

@KiwiKilian KiwiKilian commented Nov 13, 2024

I choose to align with the Android setup from current React Native Library scaffolds (via npx create-react-native-library@latest and legacy architecture) and flattened the android structure. This makes Android build for SDK 52. Also eases the path toward applying the new architecture.

@KiwiKilian KiwiKilian marked this pull request as draft November 13, 2024 08:32
@KiwiKilian KiwiKilian changed the title draft: Expo SDK 52 chore: Expo SDK 52 Nov 13, 2024
@KiwiKilian KiwiKilian changed the title chore: Expo SDK 52 chore: upgrade Expo SDK 52 Nov 13, 2024
@KiwiKilian
Copy link
Collaborator Author

KiwiKilian commented Nov 14, 2024

@Fabi755 Could you take a glimpse at the simplified gradle setup if you see something critical?

@Fabi755
Copy link

Fabi755 commented Nov 14, 2024

I never used react-native before. How can I test your changes and run the android app?
Which commands I need?

@KiwiKilian
Copy link
Collaborator Author

You need to run yarn install in the repository root. To run the examples you move to packages/expo-app or packages/react-native-app and run yarn android. If you are more a native Android dev, you might not have yarn at all?

@tyrauber
Copy link
Collaborator

@KiwiKilian This builds both expo-app and react-native-app for iOS and Android. Let's merge this in and we can make a follow up PR with more gradle optimizations as required.

@KiwiKilian KiwiKilian marked this pull request as ready for review November 15, 2024 08:45
@KiwiKilian
Copy link
Collaborator Author

@Fabi755 thanks for the input, will do those in a followup.

@tyrauber tyrauber merged commit ea1ac71 into maplibre:main Nov 15, 2024
4 checks passed
@KiwiKilian KiwiKilian deleted the feat/expo-52 branch November 19, 2024 10:12
Copy link

github-actions bot commented Dec 2, 2024

🎉 This PR is included in version 10.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants