Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: disable code signing #451

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix: disable code signing #451

merged 2 commits into from
Sep 23, 2024

Conversation

tyrauber
Copy link
Collaborator

@tyrauber tyrauber commented Sep 23, 2024 •
edited
Loading

Description

Another attempt to disable code signing of the library.

CODE_SIGN_ENTITLEMENTS = "";
CODE_SIGNING_ALLOWED = NO;

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I formatted JS and TS files with running yarn lint:fix in the root folder
  • I have run tests via yarn test in the root folder
  • I updated the documentation with running yarn generate in the root folder
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/updated a sample (/example)

Screenshot OR Video

@tyrauber tyrauber changed the title fix: CODE_SIGNING_ALLOWED NO Fix: disable code signing Sep 23, 2024
@tyrauber tyrauber merged commit 55ab2c7 into maplibre:main Sep 23, 2024
3 checks passed
@tyrauber tyrauber deleted the fix/disable-code-signing branch September 23, 2024 15:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

🎉 This PR is included in version 10.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caspg caspg caspg approved these changes

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyrauber @caspg