Call requestProgress when getting pack status on IOS + example improvement #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspg
force-pushed
the
offline-improvements
branch
from
118d18f to
8d11e05
Compare
|
🎉 This PR is included in version 10.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug when we call
getPackand state is unknown. It happened for me in my Expo app but I couldn't replicate it with example in this repo.I also fixed and migrated
CreateOfflineRegionexample to TypeScript and functional component. Example was crashing withdemotiles.I used
americanatiles since they are also used in the maplibre-native.Checklist
yarn lint:fixin the root folderyarn testin the root folderyarn generatein the root folderCHANGELOG.mdindex.d.ts)/example)Screenshot OR Video