Documentation reference maplibre #14
Conversation
There was a problem hiding this comment.
Thanks a lot @tempranova for starting to work on this! Since this is work towards a bounty, please write in the bounty issue that you would like to work on this and then @louwers can assign the ticket to you.
CONTRIBUTING.md
Outdated
| - Create a new activity inside the demo app that showcases how to use your plugin. As important as having a working plugin is to show how to use it so that anyone can include it in their projects easily. | ||
|
|
||
| - Finally, once you're ready to share your code, list your plugin in this file and then open a PR for the `@mapbox/android` team to review. | ||
| - Finally, once you're ready to share your code, list your plugin in this file and then open a PR for the `@maplibre/android` team to review. |
There was a problem hiding this comment.
Please just make it read then open a PR for "other contributors" to review.
|
The |
README.md
Outdated
| username "mapbox" | ||
| password = "SDK_REGISTRY_TOKEN" | ||
| } | ||
| url 'https://api.maplibre.com/downloads/v2/releases/maven' |
There was a problem hiding this comment.
👍, the artifacts are on maven central (see https://mvnrepository.com/artifact/org.maplibre.gl/android-plugin-annotation-v9), so this maven block can be removed.
There was a problem hiding this comment.
@tempranova If you can take care of this then we can merge it. 🙂
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| implementation 'com.mapbox.mapboxsdk:{PLUGIN_NAME}-v{MAJOR_MAPS_SDK_VERSION_NUMBER}:PLUGIN_VERSION_NUMBER' | ||
| implementation 'org.maplibre.android:{PLUGIN_NAME}-v{MAJOR_MAPS_SDK_VERSION_NUMBER}:PLUGIN_VERSION_NUMBER' |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…/tempranova/maplibre-plugins-android into documentation-reference-maplibre
|
OK, I think we're all good to go! |
…bre#12) * Fix performance when adding many individual markers to map * Thread-safe `postUpdateSource` * Replace lambda with explicit anon class We still seem to be on java language level 7
|
I was just looking at the gradle implementation to use for the scalebar plugin from this commit and it says to use "org.maplibre.android:maplibre-android-plugin-scalebar-v9:0.5.0" however I believe it's actually "org.maplibre.gl:android-plugin-scalebar-v9:1.0.0" |
|
I reverted all changes to source files due to an irreconcilable merge conflict. The changes to the Markdown files are still valuable to merge, so I am doing that now. |
Numerous updates referencing Issue .
Note that logo will not show due to path references until merged into master. Screenshot below for new logo version :)