Hide LanesView on navigation start

[Patrick-Kladek]

Checklist

• I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.
• I linked any relevant issues from https://github.com/maplibre/maplibre-navigation-ios/issues

Description

Hide LaneView when Navigation is starting but make sure it shows up if the route contains lane information

Tasks

• don't hide LanesView by adjusting alpha value
• let update(for visualInstruction: VisualInstructionBanner?) handle show & hide

Infos for Reviewer

NavigationView has a function showUI(animated: Bool = true) which showed the LanesView even when the route doesn't contain lane information. This function was called when navigation starts, therefore the next step view was double in size. After the first turn this view was then correctly hidden.

Because the all other views animate via alpha value, this could lead to a state where the LanesView wouldn't show up, as update(for visualInstruction: VisualInstructionBanner?) only changed the isHidden property, alpha could be still zero, which would prevent the view from appearing.

I've used a route in Berlin using Mapbox API to obtain a route which I know contains lane information. This is a recording form our app, please note that our map style doesn't contain map data in this region, thats why it's empty. The route works regardless and the important part, showing the LanesView appearing is visible.

[michaelkirk]

That makes sense - good find!

[Patrick-Kladek]

@hactar can you please review as well and if approved merge it.