Restore the ability to init NavVC without animations. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to maplibre#54, the NavigationViewController could only be used modally. With maplibre#54, you can switch between "map mode" and "navigation mode". To do so, an animation was introduced for the sake of smoothly transitioning from "map mode" to "navigation mode". However, if you are still using the NavigationViewController modally, this animation might interfere with other things you were doing - like setting the camera.
|
/cc @Patrick-Kladek |
hactar
reviewed
Jun 26, 2024
Patrick-Kladek
approved these changes
Jun 26, 2024
Patrick-Kladek
approved these changes
Jun 26, 2024
hactar
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #54, the NavigationViewController could only be used modally.
With #54, you can switch between "map mode" and "navigation mode".
An animation was introduced in
navigationView.showUIfor the sake of smoothly transitioning from "map mode" to "navigation mode".However, if you are still using the NavigationViewController modally, this animation might interfere with other things you were doing - like zooming before presentation.