Fix crash in EndOfRouteViewController and restore its presentation #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hactar
approved these changes
Jun 27, 2024
FIXES maplibre#57 - by rewriting EORVC as programmatic VC rather than storyboard. FIXES maplibre#62 - Omitted the "Rate this route" feedback while rewriting the EORVC. Note this was cherry-picked, and no longer works due to change in maplibre#54
Where possible, the particulars of presentation were copied from b790f96 (aka before maplibre#54).
michaelkirk
force-pushed
the
mkirk/show-end-of-route-2
branch
from
5664935 to
6e075a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of #58, extracted and rebased now that #54 is merged.
Before #54, upon completion of a route, the EndOfRouteViewController (EORVC) would be presented. It was intentionally removed in #54, but I'd like to revisit that decision. Frankly there was so much going on in #54, that I didn't realize the implications of this particular change.
I think it's a good idea to include a reasonable "you've finished the route" UI by default. Same as before #54, it can be disabled by setting
vc.showsEndOfRouteFeedback = false.Note that there is still a separate bug where the route is only considered "completed" when the route contains audio instructions. As suggested, I'll follow up with a fix for that separately.
eorvc-default.mov.mp4
For my own App, I've overridden the appearance of the button to be a "big red button", but I left the default one styled basic (as it was before my changes):
If people think this is a better default, I can upstream those style changes too.