Fix #27: navigation puck falls off route when panning #53
Conversation
The bug was especially noticeable when panning quickly or zooming in while navigating. The issue is that the upstream method signature changed in 76469a0c2227927f03a15fb95b3a20f34becc78c and then again in 8ad5f9c1fd58c60b93d26c2819637fd8f2144fd1, which first appeared in the ios-v6.0.0 tag. So our "overridden method" wasn't actually being called. It's not the commit authors fault that it broke - this is a private method we're calling. A longer term fix might be to include some kind of public stable delegate method rather than an override.
|
I just noticed there already is a delegate method: Converted to a draft while I look a bit more. |
|
Since NavigationMapView is a subclass of MLNMapView, It's often a bit tricky to mix inheritance and delegation. We want some kind of interceptor pattern. I'm sure we could come up with something, but it seems like the solution will be less than trivial, so let's start by just updating the private header for now. (re-opening the PR as is) |
|
Thanks for looking into this @michaelkirk. @mindthefish as you saw serious issues with this, would you like to give this a try if this also fixes #27? I will also give this a try 👍 |
This header was copied in from MapLibre Native to expose a private method. Previously this got out of sync and caused a bug: maplibre#53 Instead we can use the already public delegate method. Note: The deleted header was importing Maplibre/Mapbox.h, but we are using that elsewhere, so I moved that import up a level.
This header was copied in from MapLibre Native to expose a private method. Previously this got out of sync and caused a bug: maplibre#53 Instead we can use the already public delegate method. Note: The deleted header was importing Maplibre/Mapbox.h, but we are using that elsewhere, so I moved that import up a level.
This header was copied in from MapLibre Native to expose a private method. Previously this got out of sync and caused a bug: #53 Instead we can use the already public delegate method. Note: The deleted header was importing Maplibre/Mapbox.h, but we are using that elsewhere, so I moved that import up a level.
Description
The bug was especially noticeable when panning quickly or zooming in
while navigating.
The issue is that the upstream method signature changed in
maplibre/maplibre-native@76469a0 and then again in
maplibre/maplibre-native@8ad5f9c
So our "overridden method" wasn't actually being called.
It's not the commit authors fault that it broke - this is a private
method we're calling.
A longer term fix might be to include some kind of public stable
delegate method rather than an override.
Before
Simulator.Screen.Recording.-.Screenshots.5.5.iPhone.8+.-.2024-06-03.at.12.25.39.mp4.mp4
After
Simulator.Screen.Recording.-.Screenshots.5.5.iPhone.8+.-.2024-06-03.at.12.26.44.mp4.mp4
Open Tasks
Infos for Reviewer