Fix failing test for 24 hr locales #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was failing for me. I use en-US locale, but I set my clock to 24 hour. It's admittedly uncommon, but I'd wager this test is failing for anyone in a non-12 hours locale. To be honest, I expected the existing date format string `hh:mm a` to be sufficient, but apparently its not.
boldtrn
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test was failing for me. I use
en-USlocale, but I set my clock to 24 hour. It's admittedly uncommon, but I'd wager this test is failing for anyone in a non-12 hours locale.To be honest, I expected the existing date format string
hh:mm ato be sufficient, but apparently it's not.