Let speak instructions without route progress. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanPartzsch
force-pushed
the
speak-without-route-progress
branch
from
5b91c77 to
7f56bd1
Compare
boldtrn
reviewed
Mar 16, 2024
boldtrn
requested changes
Mar 16, 2024
StephanPartzsch
force-pushed
the
speak-without-route-progress
branch
2 times, most recently
from
c1363df to
39f9f27
Compare
StephanPartzsch
force-pushed
the
speak-without-route-progress
branch
from
39f9f27 to
e0339ef
Compare
boldtrn
reviewed
Mar 18, 2024
| @@ -264,8 +257,8 @@ public protocol VoiceControllerDelegate { | |||
|
|
|||
| - parameter voiceController: The voice controller that will speak an instruction. | |||
| - parameter instruction: The spoken instruction that will be said. | |||
| - parameter routeProgress: The `RouteProgress` just before when the instruction is scheduled to be spoken. | |||
| - parameter routeProgress: The `RouteProgress` just before when the instruction is scheduled to be spoken. Could be `nil` if no progress is available or if oit should be ignored. | |||
There was a problem hiding this comment.
Suggested change
| - parameter routeProgress: The `RouteProgress` just before when the instruction is scheduled to be spoken. Could be `nil` if no progress is available or if oit should be ignored. | |
| - parameter routeProgress: The `RouteProgress` just before when the instruction is scheduled to be spoken. Could be `nil` if no progress is available or if it should be ignored. |
Minor typo
boldtrn
reviewed
Mar 18, 2024
| @@ -360,7 +360,7 @@ extension ViewController: VoiceControllerDelegate { | |||
| print(interruptedInstruction.text, interruptingInstruction.text) | |||
| } | |||
|
|
|||
| func voiceController(_ voiceController: RouteVoiceController, willSpeak instruction: SpokenInstruction, routeProgress: RouteProgress) -> SpokenInstruction? { | |||
| func voiceController(_ voiceController: RouteVoiceController, willSpeak instruction: SpokenInstruction, routeProgress: RouteProgress?) -> SpokenInstruction? { | |||
There was a problem hiding this comment.
Could you please add a CHANGELOG entry for the changed APIs? Both here and for the RouteVoiceController?
boldtrn
reviewed
Mar 18, 2024
| return | ||
| } | ||
|
|
||
| open func speak(_ instruction: SpokenInstruction, with locale: Locale?, ignoreProgress: Bool = false) { |
There was a problem hiding this comment.
To be honest, I am not sure if we really need the ignoreProgress switch here?
We would need to make route progress optional as well for modifiedInstruction.attributedText(for: routeProgress.currentLegProgress).
boldtrn
requested changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.