chore: updated MapLibre Native dependency to use the ios-v6.0.0 versi…

[mindthefish]

updated MapLibre Native dependency to use the ios-v6.0.0 version (https://github.com/maplibre/maplibre-native/releases/tag/ios-v6.0.0).
Full refactoring to MapLibre / MLN naming convention still to be done.
Please test and review in-depth, as most of the refactoring was made on a find&replace base.

[boldtrn]

Thank you very much for looking into this. I will do some testing.

What's your general feeling testing this, should we rather try to merge this ASAP or keep open for testing for some time?

[mindthefish]

For me, running the sample application works as it did before the refactoring. However, I had problems loading the Mapbox map style before and after, despite the access key (or does the style only consist of single-colored country areas without roads?). So setting the pin, retrieving the route, starting active navigation, voice output, worked without problems in my tests.
I would prefer to merge as soon as possible, especially to make quick progress with the SPM PR that has just been closed. Still, I'm relatively new to Swift, so I'd be grateful if someone with more expertise would take a few minutes to review. Thank you!

[boldtrn]

or does the style only consist of single-colored country areas without roads?

Yes, this is currently intended, you can see this style used a few times here: https://maplibre.org/

You can set your own map style to overwrite this.

I would prefer to merge as soon as possible

I think this would be the best approach as well 👍

Still, I'm relatively new to Swift

Yep, same here :)

[boldtrn]

BTW: the CI failed, maybe this needs to be updated?

[mindthefish]

Thank you for the hint. I was wondering, why the CI checks did not run automatically. Can I somehow trigger the CI?

[boldtrn]

I was wondering, why the CI checks did not run automatically. Can I somehow trigger the CI?

I think your first PR needs to get merged, before that your CI runs need to be manually approved. So next PR should work automatically 👍 .

[boldtrn]

This should be MLNavigationMapViewDelegate as well?

[boldtrn]

Probably the same should apply to MBNavigationMapViewCourseTrackingDelegate?

[mindthefish]

Ok, that slipped through. The same problem exists in countless other places. Where I'm not sure: We have swapped the prefix MGL for MLN SDK-wide. But for the @objc attribute the prefix MB was used. Should we then change this to ML or align the prefix and use MLN here as well?

[boldtrn]

I think it would make sense to swap out MBGL to MLN. We could do this in this PR or do this in a follow-up. I think only renaming a smaller part would be a bit weird.

I would be fine with merging this PR sooner rather than later and do a second renaming, maybe after #24 is merged as well to avoid too many conflicts?

[mindthefish]

MGL to MLN is not the problem. I was referring to the @obj attributes which have the prefix MB with 98 occurencies in 41 files:

Is there a problem renaming them to MLN as well?

We can also wait until #24 is merged, so I can resolve the conflicts before merging this one.

[boldtrn]

I think we should rename the @objc prefixes as well. I am fine with splitting this into two different PRs.

Personally, I think the Maplibre update is pretty high prio, so I'd say, let's merge it sooner rather than later. So everyone has enough time to test the current main before we do a release. Before we are releasing a new version, we should have the renaming done.

I don't know the timeline of #24.

[boldtrn]

Very nice PR, thank you very much for working on this. Would you mind writing a Changelog entry, describing what you changed and what implementers need to change?

Also could you check the naming issue I commented on?

[boldtrn]

LGTM 👍 Thanks for working on this.

[boldtrn]

Ok, I think let's go ahead with merging this, I will create a follow-up for renaming the @objc annotations.

[mindthefish]

Ok, I think let's go ahead with merging this, I will create a follow-up for renaming the @objc annotations.

Ok, this could be part of a more general refactoring from Mapbox related naming to MapLibre. I just tried to find out which prefix works best and came across errors when renaming e.g. @objc(MBStyle) to @objc(MLNStyle), because this class name name is already defined in MapLibre native itself. So we would need to agree on a renaming scheme that works.

Thank you for approving and merging.