Overwrite rerouting logic #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindthefish
suggested changes
Jan 3, 2024
| /** | ||
| Allows to customise the calculation of a route. | ||
|
|
||
| If you want to overwrite the defult rerouting loigc, return true. |
There was a problem hiding this comment.
Suggested change
| If you want to overwrite the defult rerouting loigc, return true. | |
| If you want to overwrite the default rerouting logic, return true. |
|
|
||
| If you want to overwrite the defult rerouting loigc, return true. | ||
|
|
||
| - parameter from: The current olocation of the user |
There was a problem hiding this comment.
Suggested change
| - parameter from: The current olocation of the user | |
| - parameter from: The current location of the user |
|
|
||
| - parameter from: The current olocation of the user | ||
| - parameter along: The route progress | ||
| - parameter completion: Callbackc function when either the route was sucessfully caluclated or if there was an error |
There was a problem hiding this comment.
Suggested change
| - parameter completion: Callbackc function when either the route was sucessfully caluclated or if there was an error | |
| - parameter completion: Callback function when either the route was successfully calculated or if there was an error |
| - parameter from: The current olocation of the user | ||
| - parameter along: The route progress | ||
| - parameter completion: Callbackc function when either the route was sucessfully caluclated or if there was an error | ||
| - return: True to preferent the route controller from running its own rerouting logic |
There was a problem hiding this comment.
Suggested change
| - return: True to preferent the route controller from running its own rerouting logic | |
| - return: True to prevent the route controller from running its own rerouting logic |
|
Thanks, I just found the spellchecker in XCode, I will try my best to improve the spelling :) |
ianthetechie
approved these changes
Jan 7, 2024
There was a problem hiding this comment.
Sorry for the delay in reviewing this, but this looks good! Can't wait to try it out! Thanks @boldtrn!
|
Thanks for the review @ianthetechie, I will go ahead and merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes makes it possible to write custom rerouting logic in your app without requiring to use Mapbox directions.