Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MapboxSpeechController and Mapbox Speech dependency #12

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

boldtrn
Copy link
Collaborator

@boldtrn boldtrn commented Dec 27, 2023

Given that we try to get rid of Mapbox dependencies here, I created a PR that removes the MapboxSpeech dependency and implementation.

If you would like to continue Mapbox Speech, you can copy the deleted MapboxSpeechController into your project.

IMHO, we should not include any Mapbox dependencies (and should remove the other dependencies here in the code as well).

@boldtrn boldtrn added the enhancement New feature or request label Dec 27, 2023
@louwers
Copy link
Collaborator

louwers commented Dec 28, 2023

Sounds reasonable, but I am not really involved with the navigation repos at this point. :)

@boldtrn
Copy link
Collaborator Author

boldtrn commented Dec 29, 2023

@louwers Got it. Sorry if I tagged the wrong people here, I wasn't sure who would be the right person to request reviews from?

@louwers
Copy link
Collaborator

louwers commented Jan 1, 2024

I know @ianthetechie is into using MapLibre for navigation, but his efforts are probably focused on https://github.com/stadiamaps/ferrostar

@boldtrn boldtrn merged commit fc50bdc into maplibre:main Jan 2, 2024
1 check passed
@boldtrn boldtrn deleted the remove_mapbox_speech branch January 2, 2024 08:50
@ianthetechie
Copy link
Contributor

Hey, thanks fro the mention @louwers :)

Yes, my efforts are indeed mostly focused on Ferrostar, but I'm also happy to help out here if I can (though my time is understandably limited). I really do want the MapLibre Navigation projects to succeed as well; I'm exploring new approaches because I think it'll be easier to sustain something longer-term that's vendor-neutral first rather than a Mapbox fork in the case of the nav SDKs :D

For this specific PR, I think the changes are good. It looks like it'll still maintain speech synthesis support via the Apple local APIs, which are exactly what I think most people using this library (or Ferrostar) will want anyways.

@boldtrn
Copy link
Collaborator Author

boldtrn commented Jan 2, 2024

Thanks for the feedback @ianthetechie.

I agree and I really appreciate the efforts you are doing with Ferrostar. If we had the time and budget to fully rebuild a new nav sdk, then this would be my favorite option as well. For the time being, keeping the nav sdks working well is IMHO the best option.

If you have the time it, I'd appreciate feedback on the other PRs as well. But I can totally understand the limited time issue, I am struggling with finding enough time as well :).

For this specific PR, I think the changes are good. It looks like it'll still maintain speech synthesis support via the Apple local APIs, which are exactly what I think most people using this library (or Ferrostar) will want anyways.

Yes, that's what I was thinking as well. If anyone wants to implement MapboxVoice (or any other server side TTS), that's still possible but is out of scope of this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants