Deprecate some hardcoded mapbox styles, and replace those that remain with maplibre styles. (+docs!) #99
michaelkirkios.yml
on: pull_request
Code Style
13s
Build and Test
32m 21s
Annotations
9 errors and 21 warnings
|
Build and Test:
MapboxNavigation/NavigationViewController.swift#L430
testDestinationAnnotationUpdatesUponReroute, -[MBDayStyle copyWithZone:]: unrecognized selector sent to instance 0x60000212e490 (NSInvalidArgumentException)
|
|
Build and Test:
MapboxNavigation/NavigationViewController.swift#L430
testNavigationShouldNotCallStyleManagerDidRefreshAppearanceMoreThanOnceWithOneStyle, -[MBDayStyle copyWithZone:]: unrecognized selector sent to instance 0x60000212ff20 (NSInvalidArgumentException)
|
|
Build and Test:
MapboxNavigation/NavigationViewController.swift#L430
testNavigationShouldNotCallStyleManagerDidRefreshAppearanceMoreThanOnceWithTwoStyles, -[MBDayStyle copyWithZone:]: unrecognized selector sent to instance 0x600002132df0 (NSInvalidArgumentException)
|
|
Build and Test:
MapboxNavigation/NavigationViewController.swift#L430
testNavigationShouldNotCallStyleManagerDidRefreshAppearanceWhenOnlyOneStyle, -[MBDayStyle copyWithZone:]: unrecognized selector sent to instance 0x6000021345f0 (NSInvalidArgumentException)
|
|
Build and Test:
MapboxNavigation/NavigationViewController.swift#L430
testNavigationViewControllerDelegateRoadNameAtLocationEmptyString, -[MBDayStyle copyWithZone:]: unrecognized selector sent to instance 0x600002139540 (NSInvalidArgumentException)
|
|
Build and Test:
MapboxNavigation/NavigationViewController.swift#L430
testNavigationViewControllerDelegateRoadNameAtLocationImplemented, -[MBDayStyle copyWithZone:]: unrecognized selector sent to instance 0x600002135310 (NSInvalidArgumentException)
|
|
Build and Test:
MapboxNavigation/NavigationViewController.swift#L430
testNavigationViewControllerDelegateRoadNameAtLocationUmimplemented, -[MBDayStyle copyWithZone:]: unrecognized selector sent to instance 0x6000021376b0 (NSInvalidArgumentException)
|
|
Build and Test
Tests Failed: 7 failed, 0 skipped, 43 total (6.375 seconds)
|
|
Build and Test
Process completed with exit code 65.
|
|
Code Style:
MapboxNavigation/CarPlayManager.swift#L572
FIXMEs should be resolved (Unable to tilt map during rout...) (todo)
|
|
Code Style:
MapboxNavigation/InstructionPresenter.swift#L239
FIXMEs should be resolved (Can we work with the image dir...) (todo)
|
|
Code Style:
MapboxNavigation/NavigationMapView.swift#L743
TODOs should be resolved (Change to point-based distance...) (todo)
|
|
Code Style:
MapboxNavigation/CarPlayNavigationViewController.swift#L267
TODOs should be resolved (handle lanes.) (todo)
|
|
Code Style:
MapboxNavigation/CarPlayNavigationViewController.swift#L294
TODOs should be resolved (no such method exists, and the...) (todo)
|
|
Code Style:
MapboxCoreNavigation/RouteProgress.swift#L26
TODOs should be resolved (Set stepIndex to 0 or last ind...) (todo)
|
|
Code Style:
MapboxCoreNavigation/NavigationSettings.swift#L79
Prefer the new block based KVO API with keypaths when using Swift 3.2 or later (block_based_kvo)
|
|
Code Style:
MapboxCoreNavigation/DistanceFormatter.swift#L112
`where` clauses are preferred over a single `if` inside a `for` (for_where)
|
|
Code Style:
MapboxCoreNavigation/RouteController.swift#L175
An object should only remove itself as an observer in `deinit` (notification_center_detachment)
|
|
Code Style:
MapboxCoreNavigation/RouteController.swift#L664
Prefer `!= nil` over `let _ =` (unused_optional_binding)
|
|
Build and Test:
Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSDictionary+MLNAdditions.h' [-Wincomplete-umbrella]
|
|
Build and Test:
Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSArray+MLNAdditions.h' [-Wincomplete-umbrella]
|
|
Build and Test:
Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNConversion.h' [-Wincomplete-umbrella]
|
|
Build and Test:
Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNUserLocationHeadingIndicator.h' [-Wincomplete-umbrella]
|
|
Build and Test:
Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNUserLocationHeadingArrowLayer.h' [-Wincomplete-umbrella]
|
|
Build and Test:
Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNMapView+Metal.h' [-Wincomplete-umbrella]
|
|
Build and Test:
Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSComparisonPredicate+MLNAdditions.h' [-Wincomplete-umbrella]
|
|
Build and Test:
Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'MLNMapView+Impl.h' [-Wincomplete-umbrella]
|
|
Build and Test:
Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'NSValue+MLNStyleAttributeAdditions.h' [-Wincomplete-umbrella]
|
|
Build and Test:
Users/runner/Library/Developer/Xcode/DerivedData/maplibre-navigation-ios-hhzdlvuzrvhpkqeeyosfusshpdjz/Build/Products/Debug-iphonesimulator/MapLibre.framework/Headers/Mapbox.h#L84
umbrella header for module 'MapLibre' does not include header 'UIView+MLNAdditions.h' [-Wincomplete-umbrella]
|
|
Build and Test
xcbeautify 2.3.1 is already installed and up-to-date.
To reinstall 2.3.1, run:
brew reinstall xcbeautify
|