Bug/stencil tiles #1871
Merged
Bug/stencil tiles #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her than just the tiles for which drawables are generated. Simplify tile ID handling. Remove calls setting default stencil options.
TimSylvester
added
bug
TimSylvester
requested review from
louwers,
stefankarschti,
alexcristici,
mwilsnd and
sjg-wdw
Bloaty Results 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1871-compared-to-main.txtCompared to d387090 (legacy) Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1871-compared-to-legacy.txt |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1871 +/- ##
==========================================
+ Coverage 85.82% 85.84% +0.01%
==========================================
Files 568 568
Lines 27979 27973 -6
==========================================
Hits 24013 24013
+ Misses 3966 3960 -6 ☔ View full report in Codecov by Sentry. |
sjg-wdw
approved these changes
Nov 15, 2023
alexcristici
approved these changes
Nov 16, 2023
stefankarschti
approved these changes
Nov 16, 2023
mwilsnd
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect ordering of tiles rendered to the stencil buffer, causing low-zoom tiles to be rendered over high-zoom tiles in some cases, particularly between the completion of loading prefetch tiles (see
setPrefetchZoomDelta) and their removal.This seems to be the root cause of #1845. ... and #1846
Also fixes incorrect use of
renderTilesin the background layer and depth write options on fill drawables.https://osmus.slack.com/archives/C04SSR0S78B/p1700070024256889?thread_ts=1699920382.735459&cid=C04SSR0S78B