Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed metal background render tests #1864

Merged

Conversation

alexcristici
Copy link
Collaborator

@alexcristici alexcristici commented Nov 14, 2023

Implemented missing metal background pattern shader.

After:
Screenshot 2023-11-14 at 20 44 32

Copy link

github-actions bot commented Nov 14, 2023

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0% +7.06Ki  +0.0%    +688    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1864-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +19% +22.3Mi  +402% +24.0Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1864-compared-to-legacy.txt

Copy link
Collaborator

@sjg-wdw sjg-wdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alexcristici alexcristici merged commit f24055a into maplibre:main Nov 15, 2023
34 checks passed
@alexcristici alexcristici deleted the metal-background-render-tests branch November 15, 2023 11:07
louwers pushed a commit to louwers/maplibre-native that referenced this pull request Nov 30, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants