Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom drawable layer: Simple Fill #1810

Merged
merged 123 commits into from
Nov 6, 2023

Conversation

stefankarschti
Copy link
Collaborator

@stefankarschti stefankarschti commented Oct 26, 2023

feat: Add a simple fill to the capabilities of the custom drawable layer's interface.

Changes:

  • a Fill Generator helper has been created in mbgl::gfx. This will generate vertex, index buffers and segments compatible with the Fill shaders.
  • The FillBucket::addFeature method now uses the above Fill buffer Generator too
  • The CustomDrawableLayerHost::Interface has new methods added to manage addition of fill geometries: setFillOptions and addFill
  • platform/darwin/app/ExampleCustomDrawableStyleLayer.mm has been updated to show example usage of the new fill capability. Instantiation is done from the addCustomDrawableLayer method in MBXViewController.m.
  • The API test CustomDrawableLayer.Basic has been updated to include Fill

Refs:#1735

stefankarschti and others added 30 commits September 27, 2023 22:28
@stefankarschti stefankarschti self-assigned this Oct 26, 2023
@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.2%  +247Ki  +0.2% +63.6Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1810-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +19% +22.3Mi  +402% +24.0Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1810-compared-to-legacy.txt

@stefankarschti stefankarschti requested review from louwers, mwilsnd, TimSylvester, alexcristici and sjg-wdw and removed request for mwilsnd October 27, 2023 15:28
@stefankarschti stefankarschti marked this pull request as ready for review October 27, 2023 15:29
Copy link
Collaborator

@sjg-wdw sjg-wdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write a short summary of the changes you had to make in the PR comment?

@louwers louwers merged commit a73e88f into maplibre:main Nov 6, 2023
34 checks passed
@stefankarschti stefankarschti deleted the custom-drawable-layer-fill branch November 7, 2023 12:48
louwers pushed a commit to louwers/maplibre-native that referenced this pull request Nov 30, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Alex Cristici <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants