-
-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom drawable layer: Simple Fill #1810
Custom drawable layer: Simple Fill #1810
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1810-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1810-compared-to-legacy.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you write a short summary of the changes you had to make in the PR comment?
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Alex Cristici <[email protected]>
feat: Add a simple fill to the capabilities of the custom drawable layer's interface.
Changes:
Fill Generator
helper has been created inmbgl::gfx
. This will generate vertex, index buffers and segments compatible with the Fill shaders.FillBucket::addFeature
method now uses the above Fill buffer Generator tooCustomDrawableLayerHost::Interface
has new methods added to manage addition of fill geometries:setFillOptions
andaddFill
addCustomDrawableLayer
method in MBXViewController.m.Refs:#1735