Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore and reorganise style parameters #69

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

ntadej
Copy link
Collaborator

@ntadej ntadej commented Nov 21, 2023

Restore and reorganise style parameters:

  • Completely refactor how style parameters are done as upstream Qt does not have support anymore. While inspired by the original Qt implementation they are written from scratch and split by type.
  • They are part of the core library so that widgets can (eventually) also use them.
  • src/location/style_change_utils.cpp is pre-existing code from now deleted src/location/stylechange.cpp, just slightly cleaned-up.
  • Tests are added both for tile and image sources, including some opacity change. They will be extended in the future.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 372 lines in your changes are missing coverage. Please review.

Comparison is base (3334dc3) 35.88% compared to head (0bcfcc6) 45.66%.

❗ Current head 0bcfcc6 differs from pull request most recent head d2dd3e1. Consider uploading reports for the commit d2dd3e1 to get more accurate results

Files Patch % Lines
src/location/style_change_utils.cpp 0.00% 171 Missing ⚠️
src/core/style/layer_style_change.cpp 56.19% 46 Missing ⚠️
src/location/qgeomap.cpp 48.71% 40 Missing ⚠️
src/core/style/source_style_change.cpp 57.40% 23 Missing ⚠️
src/core/map.cpp 31.25% 22 Missing ⚠️
src/core/style/style_parameter.cpp 50.00% 15 Missing ⚠️
src/location/plugins/declarative_style.cpp 72.22% 15 Missing ⚠️
src/core/style/style_change.cpp 58.82% 14 Missing ⚠️
src/core/style/image_style_change.cpp 0.00% 13 Missing ⚠️
src/core/style/layer_parameter.cpp 72.41% 8 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   35.88%   45.66%   +9.77%     
==========================================
  Files          25       39      +14     
  Lines        1839     2190     +351     
==========================================
+ Hits          660     1000     +340     
- Misses       1179     1190      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/core/map.cpp Outdated Show resolved Hide resolved
src/core/style/image_style_change.cpp Show resolved Hide resolved
src/core/style/layer_style_change.cpp Outdated Show resolved Hide resolved
src/core/style/style_parameter.hpp Show resolved Hide resolved
@ntadej ntadej merged commit 883b791 into maplibre:main Dec 21, 2023
11 checks passed
@ntadej ntadej deleted the custom-items branch December 21, 2023 11:45
@ntadej ntadej added this to the 3.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants