Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage #68

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Add code coverage #68

merged 1 commit into from
Nov 21, 2023

Conversation

ntadej
Copy link
Collaborator

@ntadej ntadej commented Nov 20, 2023

Add code coverage with reporting to codecov.

An additional target called coverage is available which also generates HTML for local inspection.

@ntadej ntadej force-pushed the coverage branch 4 times, most recently from f4a20ef to 5bdfe17 Compare November 20, 2023 23:03
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have good knowledge of how to generate the lcov file, and I would start with simply uploading the coverage report and later on define failure threshold, but overall this looks good.

@ntadej
Copy link
Collaborator Author

ntadej commented Nov 21, 2023

I just copied and adapted the config from the main MapLibre Native. We can also ignore or revise the test later if failing too much.

@ntadej
Copy link
Collaborator Author

ntadej commented Nov 21, 2023

For reference, this is the report: https://app.codecov.io/gh/maplibre/maplibre-native-qt/tree/coverage

@ntadej ntadej merged commit 3b0db29 into maplibre:main Nov 21, 2023
11 checks passed
@ntadej ntadej deleted the coverage branch November 21, 2023 13:34
@ntadej ntadej added this to the 3.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants