Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-tidy checks and improve memory usage #65

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

ntadej
Copy link
Collaborator

@ntadej ntadej commented Nov 15, 2023

This MR improves memory handling validated by clang-tidy.

For clang-tidy the highest possible number of checks is added that makes sense (meaning not requiring large refactoring). Still there were many tiny changes needed.

Style handling refactoring will be done in a separate PR.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 211 lines in your changes are missing coverage. Please review.

Comparison is base (75366ce) 36.20% compared to head (922c7bc) 35.88%.

Files Patch % Lines
src/core/map.cpp 22.32% 87 Missing ⚠️
src/location/stylechange.cpp 0.00% 39 Missing ⚠️
src/core/conversion_p.hpp 0.00% 17 Missing ⚠️
src/location/qgeomap.cpp 63.15% 14 Missing ⚠️
src/core/geojson.cpp 0.00% 11 Missing ⚠️
src/core/types.hpp 21.42% 11 Missing ⚠️
src/core/settings.cpp 62.50% 9 Missing ⚠️
src/widgets/gl_widget.cpp 43.75% 9 Missing ⚠️
src/core/scheduler.cpp 0.00% 5 Missing ⚠️
src/location/qt_mapping_engine.cpp 82.60% 4 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   36.20%   35.88%   -0.32%     
==========================================
  Files          25       25              
  Lines        1820     1839      +19     
==========================================
+ Hits          659      660       +1     
- Misses       1161     1179      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ntadej ntadej merged commit 99255de into maplibre:main Nov 21, 2023
13 checks passed
@ntadej ntadej deleted the clang-tidy branch November 21, 2023 20:37
@ntadej ntadej added this to the 3.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants