Rework style settings and make QMapLibre::Settings more future-proof #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntadej
force-pushed
the
url
branch
2 times, most recently
from
4ce4ee4 to
1d42b39
Compare
|
I'll have a look later today. |
louwers
reviewed
Nov 14, 2023
louwers
reviewed
Nov 14, 2023
louwers
requested changes
Nov 14, 2023
louwers
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Use of smart pointers is better done in a separate PR as per discussion #57 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework style settings and make
QMapLibre::Settingsmore future-proof by using private class for data storage.A lot of work has been put into more flexible settings for QML plugin. Now most of the
QGeoMapTypeproperties can be set by providing JSON array as a value formaplibre.map.styles. A C++ equivalent ofQMapLibre::Styleis available. If unknown top-level parameters are set a warning is printed.Provider
defaultStylesare now renamed asproviderStylesand are also removed from the mainQMapLibre::Mapclass. By default no style is available. One can now also set a list of styles inQMapLibre::Settingsto be used by widgets. Furthermore default coordinate and zoom level can be set.This is in principle breaking change but it's a good time to do it now.
Closes #38 (@emericg).