Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix style filters setting #163

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Fix style filters setting #163

merged 3 commits into from
Aug 30, 2024

Conversation

ntadej
Copy link
Collaborator

@ntadej ntadej commented Aug 30, 2024

Fix style filters setting as Qt awkwardly detects QString as a list so it was iterated into a list of QChar. Also add the following improvements:

  • Add ability to remove the filter easily by setting an empty expression.
  • Add a FilterParameter helper class.

Fixes #104.

@ntadej ntadej requested review from louwers, HarelM and birkskyum August 30, 2024 18:53
@ntadej
Copy link
Collaborator Author

ntadej commented Aug 30, 2024

Will exceptionally merge this now as iOS is failing due to storage issues. As no platform-specific code is touched, this should build fine also on iOS (and does, it fails on linking).

@ntadej ntadej merged commit 02ffd8f into maplibre:main Aug 30, 2024
39 of 42 checks passed
@ntadej ntadej deleted the fix-filters branch August 30, 2024 22:04
@kebekus
Copy link

kebekus commented Oct 3, 2024

@ntadej I guess I am a little late. Still: Thanks for fixing this! I can confirm that the fix works great for my software.

@ntadej ntadej added this to the 3.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setFilter documented example returns "Error parsing filter: filter operator must be a string"
3 participants