Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Bart Louwers <[email protected]>
  • Loading branch information
ntadej and louwers authored Aug 27, 2024
1 parent 0c0ff6d commit ec8c1d5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

MapLibre Native Qt bindings and Qt Location MapLibre Plugin

**Important notice:** Repository and code has been reorganised for Qt 6.5 support.
**Important notice:** the repository and code have been reorganised for Qt 6.5 support.
Version 3.0 is a major release that includes a lot of build-related changes
and improvements and is not backwards compatible.

Expand All @@ -24,7 +24,7 @@ cd maplibre-native-qt
git submodule update --init --recursive
```

(On some file systems, the submodule update may yield `Filename too long` error
(On some file systems, the submodule update may yield a `Filename too long` error
which can be ignored.)

For more details on building the project, see [How to build](docs/Building.md).
Expand Down
4 changes: 2 additions & 2 deletions docs/Building.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ bindings build in the same step. To speed-up the build, `ninja` and `ccache`
are recommended. For Qt 6 using the `qt-cmake` wrapper instead of plain `cmake`
makes building non-desktop platforms easier.

@note To make sure correct Qt 6 version is used, use the provided toolchain file
using `-DCMAKE_TOOLCHAIN_FILE="<path-to-qt>/lib/cmake/Qt6/qt.toolchain.cmake"`
@note To make sure a correct version of Qt 6 is used, use the provided toolchain file
with `-DCMAKE_TOOLCHAIN_FILE="<path-to-qt>/lib/cmake/Qt6/qt.toolchain.cmake"`

A minimal example command is:

Expand Down
2 changes: 1 addition & 1 deletion docs/Documentation.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ cd maplibre-native-qt
git submodule update --init --recursive
```

@note On some file systems, the submodule update may yield `Filename too long`
@note On some file systems, the submodule update may yield a `Filename too long`
error. It can be ignored as only some dependencies test data will be missing.


Expand Down

0 comments on commit ec8c1d5

Please sign in to comment.