Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve generated types #86

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Improve generated types #86

merged 4 commits into from
Jul 12, 2024

Conversation

HarelM
Copy link
Contributor

@HarelM HarelM commented Jul 11, 2024

I hope this is the right solution this the problem I'm facing...

See here:
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/0919b905d898e86b4d932d6b18ab37c984bc7293/types/mapbox__vector-tile/index.d.ts#L13

I worked to make the above types as close as I could get to play nice with the other part of the app (like supercluster, geojson vt etc), so the output should resemble.

This is currently creating a type issue I would like to solve in maplibre.

Thanks for brushing up this repo!
Let me know if there's anything I can do to help out.

index.js Outdated Show resolved Hide resolved
@HarelM HarelM changed the title Update index.js type's type Improve generated types Jul 11, 2024
@HarelM
Copy link
Contributor Author

HarelM commented Jul 11, 2024

I did not manage to remove the "_" prefixed members from the index.d.ts file unfortunately.
I guess I'll have to fix the code to support this.
Let me know if you need anything else.

@mourner
Copy link
Member

mourner commented Jul 12, 2024

I did not manage to remove the "_" prefixed members from the index.d.ts file unfortunately.

Yeah, I had a similar issue, since they are used externally in this package, so can't be private. Let's leave them exposed then — seems like the right thing to do.

@mourner mourner merged commit 5b19ed0 into mapbox:main Jul 12, 2024
1 check passed
@mourner
Copy link
Member

mourner commented Jul 12, 2024

Released as v2.0.2.

@HarelM
Copy link
Contributor Author

HarelM commented Jul 12, 2024

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants