Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property marker-symbolcolor for marker text and symbol color #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lapizistik
Copy link

Rationale: the spec does not define in which color the marker-symbol
should be drawn. The spec clearly states that stroke and fill styles
shall not affect marker styles, so stroke cannot be used for this (and
the defaults of stroke and marker-color would not work well for this).

Rationale: the spec does not define in which color the marker-symbol
should be drawn. The spec clearly states that stroke and fill styles
shall not affect marker styles, so stroke cannot be used for this (and
the defaults of stroke and marker-color would not work well for this).
@jfirebaugh
Copy link

There's already a property to specify the color of the marker: marker-color. Why do we need an additional marker-symbolcolor property?

@Lapizistik
Copy link
Author

The marker color (as far as I understand the term) describes the main color of the marker (i.e. the fillcolor of the marker shape, not the color of the symbol or text printed on this background color.
Some applications default the symbol color to white, which does not work well with a white or light background. Others let you choose both colors:

Contrary (only white symbols):

I am currently working on a library which (as one feature) can show geojson with simplestyle-spec support on a map, and I support different marker-background and marker-symbol colors. I just thought it would be nice to do this following some spec ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants