Add new failing test case for a bug in tiles(), update requirements.txt
#152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
tiles()
describes itself as:This is not how it works. If the bounding box stretches across a pole,
tiles()
will not return anything.What?
This change fixes the bug and adds a few new tests to check.
These edge cases were previously not checked by ANY tests. The new function description is this:
How?
I have extended the tile-splitting algorithm to handle more splits, so that it can handle a situation where lnglat bounds straddle the "corners" of the globe. The tl;dr:
requirements.txt
I could not
pip install -r requirements.txt
in my Python 3.12 environment. To fix that, I've updated the file and included a script to do so automatically if it becomes necessary in the future.This change might be out-of-scope but is included as part of my working environment.