Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix preprocessorcer stderr failures #14

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mapsam
Copy link
Contributor

@mapsam mapsam commented Apr 25, 2016

This is a PR to test the results of updated preprocessorcer fixes, which are just an updated version of mapnik core.

cc/ @artemp @GretaCB @springmeyer @BergWerkGIS

@mapsam
Copy link
Contributor Author

mapsam commented Apr 25, 2016

Once these pass, we can discuss over at mapbox/preprocessorcerer#63

@mapsam
Copy link
Contributor Author

mapsam commented Apr 25, 2016

Looks like we are failing on tilelive-vector again.

@jakepruitt any thoughts here? Looks like expected fixtures are different than our assertions.

@mapsam
Copy link
Contributor Author

mapsam commented Apr 25, 2016

Good news is that preprocessorcer passes! @GretaCB @artemp @BergWerkGIS @springmeyer

@artemp
Copy link

artemp commented Apr 26, 2016

Ok great, thanks @mapsam

@springmeyer
Copy link
Contributor

springmeyer commented Apr 27, 2016

@mapsam - this is failing still I think because you need to point at your custom node-mapnik build. https://github.com/mapbox/mapnik-swoop/blob/preproceswizard-stderr-fix/package.json#L14 is still pointing at master node-mapnik which will pull binaries built against this version of mapnik: https://github.com/mapnik/node-mapnik/blob/master/package.json#L8 which does not have @artemp fix to unreleased Mapnik core.

@mapsam
Copy link
Contributor Author

mapsam commented May 12, 2016

I've let this fall by the wayside - will take a look at it tomorrow and hopefully get things moving again!

cc @GretaCB

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants