This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Optimization API #241
Closed
Optimization API #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address #162. I would be happy to make changes to the code, tests, etc.
At least two services,
OptimizationandDirections, rely upon identical code to handle waypoint snapping. I propose to move the relevant functions (encode_bearing,validate_radius, andvalidate_snapping) to encoding.py to avoid repeating them from service to service.When discussing the optional query parameter for
distributions, the API documentation says, "[t]he depot (first location) can only be a pick-up location, not a drop-off location." I need your assistance in determining how best to account for this in the_validate_distributionsmethod.