Display shields for destinations in turn banner #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RouteManeuverViewController is now responsible for fetching route shield images it needs to display. If the step has no code, try displaying a shield based on its destination code or, failing that, its destination.
1ec5
added
bug
frederoni
reviewed
Jul 9, 2017
| @@ -107,7 +102,6 @@ class RouteMapViewController: UIViewController { | |||
|
|
|||
| override func viewWillDisappear(_ animated: Bool) { | |||
There was a problem hiding this comment.
Nit: Let's drop this override now when it's only calling super.
frederoni
approved these changes
Jul 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly increases the frequency of route shields in the turn banner. Before, the turn banner only considered the route step’s
codefor displaying a shield, but that would only be relevant when merging onto a freeway and when approaching an off-ramp that happens to be part of a route. Now the turn banner also shows a shield based ondestinationCode, which is populated when approaching an on-ramp and when approaching an off-ramp that isn’t part of a route.Additionally, we try to treat the route step’s
destinationas adestinationCodein case it begins with a route number. This is a workaround for Project-OSRM/osrm-backend#3304 to fix #320.RouteManeuverViewController is now responsible for fetching route shield images it needs to display. This makes it easier to avoid redundant requests to Wikimedia Commons: we only issue a request when the textual representation of the shield changes.
/cc @bsudekum @frederoni @ericrwolfe @willwhite