-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAVAND-1545: introduce long routes optimised mode #7564
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChangelogFeatures
Bug fixes and improvementsKnown issues
|
dzinad
reviewed
Oct 25, 2023
parsing: suspend (ParseArguments) -> T | ||
): T { | ||
return if (routeResponseInfo.sizeBytes < options.responseToParseSizeBytes) { | ||
parsing(ParseArguments(optimiseDirectionsResponseStructure = true)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like only some parts of the optimization is enabled in this case:
- You don't preclear alternatives (this part is disabled);
- You still remove routes from the Directions Response (this part is enabled).
Is this true? If yes, is that what you wanted to achieve?
libnavigation-base/src/main/java/com/mapbox/navigation/base/utils/DecodeUtils.kt
Show resolved
Hide resolved
libnavigation-core/src/main/java/com/mapbox/navigation/core/MapboxNavigation.kt
Show resolved
Hide resolved
VysotskiVadim
added
the
needs backporting
Requires cherry-picking to a currently running release branch
label
Oct 27, 2023
dzinad
approved these changes
Oct 27, 2023
VysotskiVadim
added a commit
that referenced
this pull request
Oct 27, 2023
dzinad
pushed a commit
that referenced
this pull request
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a special model for long routes handling which is activated by
LongRoutesOptimisationOptions
. When it's active, the SDK changes behaviour to be able to handle heavy routes:NavigationRoute.directionsResonse.routes
always returns an empty list, so that route objects of dropped alternatives could be removed from memory.Besides the optimised mode, there are a few optimisations which are always working: