Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NN-843 #7349

Merged
merged 8 commits into from
Jul 7, 2023
Merged

NN-843 #7349

merged 8 commits into from
Jul 7, 2023

Conversation

dzinad
Copy link
Contributor

@dzinad dzinad commented Jul 7, 2023

Description

Screenshots or Gifs

@dzinad dzinad requested a review from a team as a code owner July 7, 2023 14:59
@github-actions
Copy link

github-actions bot commented Jul 7, 2023 •
edited
Loading

Changelog

Features

  • Added new options to RouteLineColorResources to style congestion, restrictions, and closures colors on inactive legs when MapboxRouteLineOptions#styleInactiveRouteLegsIndependently is enabled. The values default to transparent. [#7322](https://github.com/mapbox/mapbox-navigation-android/pull/7322)

Bug fixes and improvements

  • Fixed an issue where RoutingTilesOptions#tilesBaseUri was used as a base url for route refresh requests instead of RouteOptions#baseUrl. [#7294](https://github.com/mapbox/mapbox-navigation-android/pull/7294)
  • Added a Copilot option that allows to disable recording Free Drive histories. [#7276](https://github.com/mapbox/mapbox-navigation-android/pull/7276)
  • Route request timeout errors are now considered failures as opposed to cancellations (NavigationRouterCallback#onFailure will be invoked instead of NavigationRouterCallback#onCanceled). [#7319](https://github.com/mapbox/mapbox-navigation-android/pull/7319)
  • Fixed an issue where location might have been snapped to an incorrect road when previously location updates had been inactive. [#7319](https://github.com/mapbox/mapbox-navigation-android/pull/7319)
  • Fixed an issue where in case of poor location signal it might have been snapped to a road, which is above/below the correct one. [#7319](https://github.com/mapbox/mapbox-navigation-android/pull/7319)
  • Added experimental metadata property to LegWaypoint class. This property exposes the corresponding DirectionsWaypoint#metadata. [#7259](https://github.com/mapbox/mapbox-navigation-android/pull/7259)
  • Added Copilot option that allows to split history files by duration. [#7232](https://github.com/mapbox/mapbox-navigation-android/pull/7232)
  • Added Copilot options that allow to limit the number and total size of history files to be sent per session. [#7232](https://github.com/mapbox/mapbox-navigation-android/pull/7232)
  • Fixed an issue where RouteReplaySession might not have started playing a route if it was created approximately at the same time when routes were set to MapboxNavigation. [#7293](https://github.com/mapbox/mapbox-navigation-android/pull/7293)
  • Added experimental and temporary (i.e. it will be removed in one of the next releases) OnlineRouteAlternativesSwitch which requests online route when the current route is offline and automatically switches if such a route is found. It's designed for the case when platform's reachability API doesn't work reliably. [#7245](https://github.com/mapbox/mapbox-navigation-android/pull/7245)
  • Improved Copilot to send a proper type with events of type DriveEndsEvent. [#7236](https://github.com/mapbox/mapbox-navigation-android/pull/7236)
  • Added experimental MapboxNavigation#etcGateApi so that the app can provide data about passed ETC gates. [#7295](https://github.com/mapbox/mapbox-navigation-android/pull/7295)
  • Fixed an issue where road closures where not displayed for inactive legs of the route. [#7322](https://github.com/mapbox/mapbox-navigation-android/pull/7322)

Known issues ⚠️

  • In case an app provides custom Router implementation to Nav SDK, the Nav SDK doesn't trigger NavigationRouteAlternativesObserver with online alternatives when current route is offline.

Other changes

Android Auto Changelog

Features

Bug fixes and improvements

@VysotskiVadim VysotskiVadim changed the title tmp NN-843 Jul 7, 2023
@DzmitryFomchyn DzmitryFomchyn merged commit 2b876a3 into main Jul 7, 2023
@DzmitryFomchyn DzmitryFomchyn deleted the dd-tmp-2 branch July 7, 2023 21:32
@mapbox-github-ci-issues-3 mapbox-github-ci-issues-3 bot mentioned this pull request Jul 7, 2023
Closed
dzinad
dzinad commented Jul 10, 2023
View reviewed changes
changelog/unreleased/issues/changes.md
@@ -0,0 +1 @@
- In case an app provides custom `Router` implementation to Nav SDK, the Nav SDK doesn't trigger `NavigationRouteAlternativesObserver` with online alternatives when current route is offline.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really so? I thought it was more like "it's triggered, but much later". The alternatives mechanism is still working, right? we just won't trigger an alternative request as soon as the network is back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@averkhaturau, can you please clarify consequences of using custom router for offline-online switch?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NN knows which router is online only if it creates the routers itself. Providing a custom router makes this information unavailable, we don't know how to create an online router anymore. That's why the back online feature will not be available with a custom router

libnavigation-core/src/main/java/com/mapbox/navigation/core/MapboxNavigation.kt
// on implementation details in some cases like offline-online switch.
// Meanwhile platform SDK uses its own instance of native router for
// route requests
null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also pass nativeRouter in recreate method. It should also be null.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one! fixing in a followup PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7357

@VysotskiVadim VysotskiVadim mentioned this pull request Jul 10, 2023
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VysotskiVadim VysotskiVadim VysotskiVadim left review comments

@averkhaturau averkhaturau averkhaturau left review comments

@DzmitryFomchyn DzmitryFomchyn DzmitryFomchyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dzinad @averkhaturau @DzmitryFomchyn @VysotskiVadim