Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v3.8.0 #13323

Merged
merged 39 commits into from
Nov 12, 2024
Merged

v3.8.0 #13323

merged 39 commits into from
Nov 12, 2024

Conversation

mourner
Copy link
Member

@mourner mourner commented Nov 12, 2024

Features and improvements ✨

  • Add experimental support for style-defined featuresets, an upcoming way to query features in Mapbox Standard and other fragment-based styles.
  • Add experimental Map addInteraction/removeInteraction methods that make it easier to manage map interactions like clicking and hovering over features.
  • Add experimental support for elevated lines with line-cross-slope and line-elevation-reference properties.
  • Add experimental scaleFactor map option and setScaleFactor method to increase map label size (useful for improving accessibility or adjusting text size for different devices).
  • Add support for using line-progress expression in non-data-driven line properties.
  • Improve performance of dynamic brightness changes.
  • Minor optimizations to reduce load time.

Bug fixes 🐞

  • Fix localization when setting a worldview on the Mapbox Standard style.
  • Fix raster array rendering on some Android devices.
  • Fix an issue where fill-extrusion buildings would disappear when zooming out.
  • Fix line joins for thick semi-transparent or blurred lines.
  • Improve appearance of line corners with densely placed vertices.
  • Fix anti-alising aftifacts on blurred lines.
  • Fix call stack overflow caused by repeated addImport calls.
  • Fix failures when handling non-renderable characters.
  • Fix rendering of Osage script.
  • Fix certain edge cases when using config expression in filter properties.
  • Fix patterned fill extrusions being visible with zero opacity alpha.
  • Fix data-driven symbol-z-offset not working properly.
  • Fix fill extrusions on terrain producing WebGL warnings in some cases.
  • Fix line-emissive-strength not being applied to patterned lines.

dependabot bot and others added 30 commits November 12, 2024 13:11
@dependabot @mourner
Bump the vitest-dependencies group with 3 updates (internal-1947)
4b99ee4 
Bumps the vitest-dependencies group with 3 updates: [@vitest/browser](https://github.com/vitest-dev/vitest/tree/HEAD/packages/browser), [@vitest/ui](https://github.com/vitest-dev/vitest/tree/HEAD/packages/ui) and [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest).


Updates `@vitest/browser` from 2.1.3 to 2.1.4
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v2.1.4/packages/browser)

Updates `@vitest/ui` from 2.1.3 to 2.1.4
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v2.1.4/packages/ui)

Updates `vitest` from 2.1.3 to 2.1.4
- [Release notes](https://github.com/vitest-dev/vitest/releases)
- [Commits](https://github.com/vitest-dev/vitest/commits/v2.1.4/packages/vitest)

---
updated-dependencies:
- dependency-name: "@vitest/browser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: vitest-dependencies
- dependency-name: "@vitest/ui"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: vitest-dependencies
- dependency-name: vitest
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: vitest-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump @types/jest from 29.5.13 to 29.5.14 (internal-1950)
541112f 
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 29.5.13 to 29.5.14.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

---
updated-dependencies:
- dependency-name: "@types/jest"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump playwright from 1.48.1 to 1.48.2 (internal-1951)
b661df9 
Bumps [playwright](https://github.com/microsoft/playwright) from 1.48.1 to 1.48.2.
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.48.1...v1.48.2)

---
updated-dependencies:
- dependency-name: playwright
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump st from 3.0.0 to 3.0.1 (internal-1952)
8f5c9cf 
Bumps [st](https://github.com/isaacs/st) from 3.0.0 to 3.0.1.
- [Commits](isaacs/st@v3.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: st
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump tsx from 4.19.1 to 4.19.2 (internal-1953)
51ef9ad 
Bumps [tsx](https://github.com/privatenumber/tsx) from 4.19.1 to 4.19.2.
- [Release notes](https://github.com/privatenumber/tsx/releases)
- [Changelog](https://github.com/privatenumber/tsx/blob/master/release.config.cjs)
- [Commits](privatenumber/tsx@v4.19.1...v4.19.2)

---
updated-dependencies:
- dependency-name: tsx
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@stepankuzmin @mourner
Don't send sdk version in the dev build (internal-1924)
ba756d0 
* Don't send sdk version in dev build
@dependabot @mourner
Bump @types/node from 22.7.7 to 22.8.2 (internal-1949)
1588523 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.7.7 to 22.8.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alexey-romanov @mourner
[GLJS-1061] fix WebGL warnings for fill extrusion texture. (internal-…
b3d1e75 
…1957)

Texture was created via texStorage which is incompatible with texImage2D. Use texSubImage2D instead.
@lasselammi @mourner
[MAPS3D-1509] Add fill-elevation-reference layout property (internal-…
810625e 
…1955)

* Add fill-elevation-reference layout property

* Generate style code
@stepankuzmin @mourner
Improve Worker types (internal-1956)
5564357 
* Improve Worker types
@underoot @mourner
Added support of usvg_pb 0.6.0 (internal-1958)
96abc46
@mourner
Improve USVG rasterization (internal-1960)
5f8deae 
* usvg: fallback to miter on miter-clip

* usvg: move patterns to unsupported section of ignores

* remove usvg tests that pass from ignores

* usvg: fix gradient opacity

* usvg: fix mask sizing

* usvg: better logic for multiple clip paths

* usvg: fix mask clipping

* usvg: fix recursive mask application

* usvg: fix handling luminance mask alpha

* usvg: fix transformations on clip groups; reorganize ignores

* better comments in ignores

* usvg ignores comment fixes

* update comments on usvg ignores
@underoot @mourner
GLJS-1080 Fixed unit tests (internal-1961)
dc926f2
@nicozink @astojilj @mourner
MAPS3D-1482: Port terrain fix and optimisations from gl-native (inter…
a4b03ec 
…nal-1910)

* Port terrain fixes from gl-native to gl-js

* Terrain fixes
- Move attenuation zoom adjustment to update
- Fix upscale calucation function
- Refresh order when terrain is enabled/disabled

* Fix and rerun render tests after offset line rendering changes
- Discussed the changes with Lasse
- Enable these tests

* Lint fix

* Activate (still broken) render test

* Fix unit tests by replacing getTerrain with temp variable

* Resolve stencil clear for elevated lines

stencil invalidate was done before resetting forced terrain. In gl-js, contrary to gl-native we have a code like this:

    resetStencilClippingMasks() {
        if (!this.terrain) {
            this.currentStencilSource = undefined;
            this._tileClippingMaskIDs = {};
        }
    }

Handling clear and invert was done to follow This would make sense to refactor and make the same in both.

* Cleanup

---------

Co-authored-by: Aleksandar Stojiljković <[email protected]>
@astojilj @mourner
experimental paint property symbol-elevation-reference set to be layo…
35b72a5 
…ut property (internal-1963)

3D intersections requires some additional work in bucket that is not suitabkle for handling within frame
@astojilj @mourner
[MAPS3D-1479] Allow reordering only when layers minzoom is above terr…
36aee31 
…ain maxzoom (internal-1964)

PR mapbox/mapbox-gl-js-internal#1910 presents problematic change that order changes when terrain gets disabled (as it the behavior in gl-native).

This PR strengthens back the implementation while allowing keeping the original order under one condition - do not reorder layers to draped/nondraped bucket for those layers that don't show in terrain zoom range.
In gl-native, the condition is more relaxed (when terrain is disabled, use the original order).

This fixes the critical issue for Standard Style HD - SD integration: https://mapbox.atlassian.net/jira/software/c/projects/MAPS3D/issues/MAPS3D-1479
@persidskiy @mourner
Debug page for IME (internal-1923)
ac21677
@speps @mourner
Add support for shadows from elevated structures (internal-1921)
43acf33 
* Add shadow support for fill shaders
* Add shadow support for line shaders
* Move where RENDER_SHADOWS is defined (per program instead of global)
* Check for shadows related uniforms to be properly set when the RENDER_SHADOWS is set
@endanke @mourner
Fix access of retainedQueryData with elevated symbols (internal-1970)
6b6caae
@endanke @mourner
Prevent re-evaluation of buckets on small brightness change (internal…
1d42b3e 
…-1973)
@dependabot @mourner
Bump tweakpane from 4.0.4 to 4.0.5 (internal-1967)
1cefded 
Bumps [tweakpane](https://github.com/cocopon/tweakpane) from 4.0.4 to 4.0.5.
- [Release notes](https://github.com/cocopon/tweakpane/releases)
- [Commits](cocopon/tweakpane@4.0.4...4.0.5)

---
updated-dependencies:
- dependency-name: tweakpane
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump @tweakpane/core from 2.0.4 to 2.0.5 (internal-1968)
b569147 
Bumps @tweakpane/core from 2.0.4 to 2.0.5.

---
updated-dependencies:
- dependency-name: "@tweakpane/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump @types/node from 22.8.2 to 22.8.7 (internal-1965)
a8659a1 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.8.2 to 22.8.7.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@underoot @mourner
Vitest tests improvements (internal-1962)
2575f19 
* Vitest tests improvements

* Cleaned-up terrain.test
@lasselammi @mourner
[MAPS3D-1423] Fix elevated lines rendering issue (internal-1969)
3e73217 
* Set overrideRtt to false for elevated lines

* Fix gamma scale for line-cross-slope: 1

* Update elevated line render test expectations

* Simplify elevated lines distance calculation
@endanke @mourner
Hide patterned fill extrusions with zero opacity alpha (internal-1974)
c615f3f
@stepankuzmin @mourner
[GLJS-1043] Add $localized=true to localized features (internal-1959)
59e8a47
@endanke @mourner
Fix usage of config expression in filter properties (internal-1975)
7251a0d 
* Add test for config in clip layer filter

* Fix usage of config expression in filter properties
@jtorresfabra @mourner
Fix QRF for meshopt landmarks (internal-1980)
f36d809 
Use the correct aabb to build the grid, and remove incorrect duplicated node matrix transform in queryIntersectsMatchingFeature
@jtorresfabra @mourner
Add qrf tests for meshopt models (internal-1981)
a442052
endanke and others added 9 commits November 12, 2024 13:11
@endanke @mourner
Always evaluate expressions with line-progress (internal-1982)
0ebd875
@speps @mourner
Fix naming conflict in line shaders (internal-1984)
8fd8ffa
@stepankuzmin @mourner
[GLJS-1091] Add feature state support in 3D models (internal-1983)
3558887
@lasselammi @mourner
[MAPS3D-1498] Add support for line-pattern emissive strength (interna…
4d9801e 
…l-1987)

* Add emissive strength support to line-pattern

* Add render test
@astojilj @mourner
Revert "[MAPS3D-1479] Allow reordering only when layers minzoom is ab…
1995e3a 
…ove terrain maxzoom (internal-1964)" (internal-1989)

This reverts commit c08008cc62dbad8de7930e9e0ac0027afbdb799c.

When increasing zoom, allow changing the layer order when the globe, or optional terrain, gets disabled. For generic fragment development, it is ambiguous to define fragments that cover both cases of a customer style with terrain (so layers from fragment forcefully reordered) and a customer style without terrain. It is easier to explain to all explicitly: enabled terrain and globe reorder layer. Customer can tweak at what zoom levels to disable terrain.

Render tests remain.
@dependabot @mourner
Bump postcss from 8.4.47 to 8.4.49 (internal-1991)
11dbf89 
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.47 to 8.4.49.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.47...8.4.49)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mourner
Bump @types/node from 22.8.7 to 22.9.0 (internal-1992)
c1e8947 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.8.7 to 22.9.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@stepankuzmin @mourner
[GLJS-1062] Improve queryRenderedFeatures support in the Interactio…
b86a1ab 
…ns API (internal-1945)
@mourner
v3.8.0
4b358c3 
* v3.8.0

* update changelog

* add Interactions API to changelog
@mourner mourner requested a review from a team as a code owner November 12, 2024 11:13
stepankuzmin
stepankuzmin approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mourner mourner merged commit 4b358c3 into main Nov 12, 2024
34 checks passed
@mourner mourner deleted the mourner/v3.8.0 branch November 12, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepankuzmin stepankuzmin stepankuzmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.