Fix type narrowing of image source types #13221
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR attempting to fix #13220. I don't think it's the best approach, but it might be useful for discussions.
The core problem of #13220 is that the new
ImageSource
type is serving double-duty as the basis for theCanvasSource
andVideoSource
types. This means that thetype
property is currently typed asstring
, which prevents type narrowing from working on theSource
type.The solution here does work, but having
ImageSource
be a generic type is probably not the nicest way to do it. Perhaps theImageSource
type should be separated from its implementation?Launch Checklist
@mapbox/map-design-team
@mapbox/static-apis
if this PR includes style spec API or visual changes. (N/A)@mapbox/gl-native
if this PR includes shader changes or needs a native port. (N/A)