Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release-v2.0 to main (as of v2.0.0-beta.5) #558

Merged
merged 49 commits into from
Jul 1, 2021
Merged

Merge release-v2.0 to main (as of v2.0.0-beta.5) #558

merged 49 commits into from
Jul 1, 2021

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jul 1, 2021

This PR merges the release-v2.0 branch to the main branch. The release-v2.0 branch is where we’ve been developing MapboxDirections v2.0.0 over the past six months or so. A release-v1.2 branch has already been created with the current state of the main branch, in order to track any out-of-band patch releases that may be required over the coming months. However, v2.x has already been the focus of development for some time. Synchronizing the main branch ensures that nothing slips through the cracks as we put out v2.0.0 and sets the stage for v2.1 work to begin soon.

In case this PR is too large to review manually, please see the changelog and migration guide. Unlike in mapbox/mapbox-navigation-ios#3115, the license of this repository is not changing; it will continue to be the ISC license.

/cc @mapbox/navigation-ios

1ec5 and others added 30 commits February 18, 2021 12:08
* Change Turf dependency to a binary version

* Turf v2.0.0-alpha.2

* Removed tvOS, watchOS, Linux support

Co-authored-by: Alexander Pristavko <[email protected]>
* Implement initial IncidentImpact enum.

* Make Impact codable.

* Update RouteStepTests: add XCTAssert for Incident.Impact.

* Update CHANGELOG.md

Co-authored-by: Minh Nguyễn <[email protected]>
* add new properties to VisualInstruction.Component and Intersection; update tests
* add string conversion to VisualInstruction.component.lane preferredDirection property, update relevant tests
* preferred lane direction is now of type ManeuverDirection, tests updated accordingly
Cherry-picked from 2ffc5f0.
Remove excessive logging from Intersection.
Fixes #539.

SPM 5.4 has automatic test discovery support, so that we can remove
manually generated files for running Linux tests.
S2Ler and others added 19 commits May 31, 2021 16:18
In order to support M1 based development and remove the need for
Carthage workaround we must migrate to XCFrameworks.
It runs Carthage from the library user point of view and verifies that
it can be built successfully.
Xcode 11 no longer supported with the previous changes because you need
Xcode 12 so that Carthage can build the project.
Upgrade SPM version to 5.4 for Linux builds
Co-authored-by: Minh Nguyễn <[email protected]>
SPM tests can't contain Info.plist which is used for injecting default
access token into the library.

With this addition SPM tests can set access token using `MBXAccessToken`
key in NSUserDefaults which will be used in `defaultAccessToken`
initialization.
@1ec5 1ec5 added the build label Jul 1, 2021
@1ec5 1ec5 added this to the v2.0.0 (RC) milestone Jul 1, 2021
@1ec5 1ec5 requested a review from a team July 1, 2021 00:31
@1ec5 1ec5 self-assigned this Jul 1, 2021
Copy link
Contributor

@jill-cardamon jill-cardamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@1ec5 1ec5 merged commit 773a627 into main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants