-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release-v2.0 to main (as of v2.0.0-beta.5) #558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change Turf dependency to a binary version * Turf v2.0.0-alpha.2 * Removed tvOS, watchOS, Linux support Co-authored-by: Alexander Pristavko <[email protected]>
* Implement initial IncidentImpact enum. * Make Impact codable. * Update RouteStepTests: add XCTAssert for Incident.Impact. * Update CHANGELOG.md Co-authored-by: Minh Nguyễn <[email protected]>
Add fallback access token.
* add new properties to VisualInstruction.Component and Intersection; update tests
* add string conversion to VisualInstruction.component.lane preferredDirection property, update relevant tests
* preferred lane direction is now of type ManeuverDirection, tests updated accordingly
Cherry-picked from 2ffc5f0.
Remove excessive logging from Intersection.
Release v2.0.0-beta.4
Fixes #539. SPM 5.4 has automatic test discovery support, so that we can remove manually generated files for running Linux tests.
In order to support M1 based development and remove the need for Carthage workaround we must migrate to XCFrameworks.
It runs Carthage from the library user point of view and verifies that it can be built successfully.
Xcode 11 no longer supported with the previous changes because you need Xcode 12 so that Carthage can build the project.
Upgrade SPM version to 5.4 for Linux builds
Co-authored-by: Minh Nguyễn <[email protected]>
Example Update with XCFrameworks
SPM tests can't contain Info.plist which is used for injecting default access token into the library. With this addition SPM tests can set access token using `MBXAccessToken` key in NSUserDefaults which will be used in `defaultAccessToken` initialization.
jill-cardamon
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the release-v2.0 branch to the main branch. The release-v2.0 branch is where we’ve been developing MapboxDirections v2.0.0 over the past six months or so. A release-v1.2 branch has already been created with the current state of the main branch, in order to track any out-of-band patch releases that may be required over the coming months. However, v2.x has already been the focus of development for some time. Synchronizing the main branch ensures that nothing slips through the cracks as we put out v2.0.0 and sets the stage for v2.1 work to begin soon.
In case this PR is too large to review manually, please see the changelog and migration guide. Unlike in mapbox/mapbox-navigation-ios#3115, the license of this repository is not changing; it will continue to be the ISC license.
/cc @mapbox/navigation-ios