forked from uw-psych/hyakvnc
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preload oras://ghcr.io SIF images for better UX #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preloads oras://ghcr.io SIF images for better UX -- shows download progress.
This should not be necessary as of Apptainer v1.2.3 (2023-09-14):
But
klone
hasapptainer
1.1.5 installed. Ideally, we should be able to remove this whenklone
upgrades theapptainer
version.The implementation uses
curl
to query the ghcr API in roughly the same wayapptainer
does it ininternal/pkg/client/oras/oras.go
. It usespython3
to parse the JSON responses and downloads the blob for the image directly to$APPTAINER_CACHEDIR/cache/oras
, which is whereapptainer
looks for a cached image fromoras://ghcr.io
(Thisapptainer
cache behavior might change in the future.).If anything goes wrong, the preload will fail and
hyakvnc
will carry on.