Fix Avatar initials color hashing to use full name #7322
Merged
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…colors for same initials with different names 🎨 By removing `getInitials` from `hashCode`, the function now uses the full name to generate a hash. This ensures that even if two names produce the same initials, their colors will differ if their full names are different.
Updated test cases to reflect the new functionality of `getInitialsColor`, ensuring accurate results and preventing future test failures.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In the Avatar component, the
getInitialsColorfunction was using only the initials of a name to generate a hash, which determined the color of the avatar. This led to the issue where different names with the same initials would receive the same color, even if the full names were different.Solution:
The function now uses the full name to generate the hash. By removing the use of
getInitials()inside thehashCode()call, each unique name will produce a unique hash, ensuring a unique color for each different name.Details:
hashCode()call is updated to process the entire name, not just the initials.getInitialsColorfunction remains consistent, mapping the hash to an index in the colors array.Impact: