Improve numerical third derivative #139
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function for the numerical third derivative trims the range of x by 6 columns on each side. In order to match the shape of the data, the solution is to extend the range of y space so that both y space and the resulting JOfY function have 6 more points than needed on each side. After the third derivative is computed, trim JOfY to match shape of FSE. This solution avoids padding the FSE corrections with zeros, and maintains the same computational speed.
GuiMacielPereira
force-pushed
the
fix-third-derivative-padding
branch
from
9d08438
to
3d27b18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
Function for calculating the third derivative numerically used to pad edges with zeros, which is not desirable.
This slight change makes sure the edges are smooth.
To test:
Fixes #xxxx.