Make image view mixins into abstract base classes #2374
+23
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
2373-mixins-abc
branch
from
a8dfb10
to
9670f79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #2373
Wait for #2349 to be merged to resolve any conflicts
Description
Add a derived metaclass, to avoid metaclass conflicts. This is needed because the imageview has a
sip.wrappertypemetatype from qt.Change
AutoColorMenuandBadDataOverlayto abstract base classes.Testing & Acceptance Criteria
Should not cause any problems, if the tests pass everything should work
Documentation
Not needed.